Skip to content

Add support for UUIDv6 and UUIDv8 validation #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

Add support for UUIDv6 and UUIDv8 validation #1636

merged 2 commits into from
Feb 17, 2025

Conversation

@astei
Copy link
Contributor

@astei astei commented Feb 14, 2025 •
edited by pydantic-hooky bot
Loading

Change Summary

Adds support for validating v6 and v8 UUIDs. UUID version 6 and 8 defined in RFC 9562.

Upon request from from @Viicos on pydantic/pydantic#11436, creating this PR to wire up UUID v6 and v8 validation support.

Related issue number

n/a

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (ab503cb) to head (7b2e241).
Report is 293 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   90.21%   89.55%   -0.67%     
==========================================
  Files         106      115       +9     
  Lines       16339    17920    +1581     
  Branches       36       25      -11     
==========================================
+ Hits        14740    16048    +1308     
- Misses       1592     1853     +261     
- Partials        7       19      +12
Files with missing lines Coverage Δ
python/pydantic_core/core_schema.py 95.08% <ø> (+0.31%) ⬆️
src/validators/uuid.rs 98.64% <100.00%> (+0.05%) ⬆️

... and 64 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741961c...7b2e241. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1636 will not alter performance

Comparing astei:astei/add-uuidv6v8 (7b2e241) with main (741961c)

Summary

✅ 157 untouched benchmarks

@astei
Copy link
Contributor Author

astei commented Feb 14, 2025

please review

@astei astei mentioned this pull request Feb 14, 2025
Merged
5 tasks
@Viicos
Copy link
Member

Viicos commented Feb 14, 2025 •
edited
Loading

Thanks @astei. Is it possible to also update this comment?

pydantic-core/src/validators/uuid.rs

Lines 138 to 147 in 741961c

// This block checks if the UUID version matches the expected version and
// if the UUID variant conforms to RFC 4122. When dealing with Python inputs,
// UUIDs must adhere to RFC 4122 standards.
if let Some(expected_version) = self.version {
if uuid.get_version_num() != expected_version || uuid.get_variant() != Variant::RFC4122 {
return Err(ValError::new(
ErrorType::UuidVersion {
expected_version,
context: None,
},

With something along the lines of:

This block checks if the UUID version matches the expected version and
if the UUID variant conforms to RFC 9562 (superseding RFC4122) . When dealing with Python inputs,
UUIDs must adhere to RFC 9562 standards.

@Viicos Viicos changed the title Add support for UUIDv6 and UUIDv8 validation as well Add support for UUIDv6 and UUIDv8 validation Feb 14, 2025
Viicos
Viicos approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Viicos Viicos merged commit a0e60bd into pydantic:main Feb 17, 2025
28 of 29 checks passed
@vasudev-gm vasudev-gm mentioned this pull request Mar 7, 2025
Closed
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
@astei
Add support for UUIDv6 and UUIDv8 validation (pydantic/pydantic-core#…
4ff3c96 
…1636)

Original-commit-hash: a0e60bd
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
@astei
Add support for UUIDv6 and UUIDv8 validation (pydantic/pydantic-core#…
342d584 
…1636)

Original-commit-link: pydantic/pydantic-core@a0e60bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@sydney-runkle sydney-runkle

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astei @Viicos @sydney-runkle